feat: Parse Azure Function HttpTrigger parameters #2776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from code coverage.
…wrelic-dotnet-agent into chore/update-serilog
chore: Update Profiler NuGet Package Reference to v10.28.0.40. Co-authored-by: tippmar-nr <[email protected]>
…azure-function-instrumentation
* Profiler update to exclude func.exe * chore: Update Profiler NuGet Package Reference to v10.29.0.54 (#2734) chore: Update Profiler NuGet Package Reference to v10.29.0.54. Co-authored-by: tippmar-nr <[email protected]> * WIP * profiler azure function detection rework * Azure function integration tests functional but not complete * Upate all_solutions workflow to install azure functions tools and test the azurefunction namespace * another install attempt * test only azure function namespace for now * Tweaks for the integration tests workflow * enable all namespaces for integration tests * cleanup * Profiler: Allow log level override in azure function mode via NEW_RELIC_AZURE_FUNCTION_LOG_LEVEL_OVERRIDE=1 * workflow tweak * chore: Update Profiler NuGet Package Reference to v10.29.0.66 (#2738) chore: Update Profiler NuGet Package Reference to v10.29.0.66. Co-authored-by: tippmar-nr <[email protected]> * integration test tw4eaks * profiler unit test update --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Integration test updates, added net6.0 and net8.0 plus a test to verify behavior when azure function mode is disabled. * Integration test rework to use different HttpTrigger invocation methods
Disable aspnetcore middleware wrapper in azure function mode, update integration tests
…/newrelic-dotnet-agent into feature/azure-functions
* Added QueueTrigger function to integration tests * Added a missing file * Minor refactor
…ts to exercise more scenarios.
…o feature/azure-function-http-trigger-parsing
tippmar-nr
commented
Sep 18, 2024
chynesNR
reviewed
Sep 19, 2024
...gent/NewRelic/Agent/Extensions/Providers/Wrapper/AzureFunction/InvokeFunctionAsyncWrapper.cs
Outdated
Show resolved
Hide resolved
chynesNR
reviewed
Sep 19, 2024
...gent/NewRelic/Agent/Extensions/Providers/Wrapper/AzureFunction/InvokeFunctionAsyncWrapper.cs
Outdated
Show resolved
Hide resolved
…/github.com/newrelic/newrelic-dotnet-agent into feature/azure-function-http-trigger-parsing
nrcventura
reviewed
Sep 19, 2024
src/Agent/NewRelic/Agent/Extensions/Providers/Wrapper/AzureFunction/AzureFunction.csproj
Outdated
Show resolved
Hide resolved
nrcventura
reviewed
Sep 19, 2024
tests/Agent/IntegrationTests/IntegrationTests/AzureFunction/AzureFunctionHttpTriggerTests.cs
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2776 +/- ##
==========================================
- Coverage 81.24% 81.23% -0.02%
==========================================
Files 460 460
Lines 29229 29230 +1
Branches 3223 3223
==========================================
- Hits 23747 23744 -3
- Misses 4696 4698 +2
- Partials 786 788 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nrcventura
approved these changes
Sep 20, 2024
chynesNR
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements parsing for request method, request uri and response status code for Azure Functions that utilize
HttpTrigger.Includes updated integration tests that exercise an Azure Function app that uses the
Microsoft.Azure.Functions.Worker.Extensions.Http.AspNetCorepackage and one that does not, to verify that we can correctly parse the data we need in both scenarios.(Don't be scared by the ridiculously large commit history - this branch started out as a feature work branch back when the Azure Functions feature was still around...)